Skip to content

Fix iOS 26 release tag trigger and version extraction - #147

Merged
rdlabo merged 1 commit into
ios26from
fix/ios26-release-tag-prefix
Sep 10, 2026
Merged

Fix iOS 26 release tag trigger and version extraction#147
rdlabo merged 1 commit into
ios26from
fix/ios26-release-tag-prefix

Conversation

@rdlabo

@rdlabo rdlabo commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

The iOS 26 release command creates ios26-v* tags via .npmrc, but the workflow only accepted v*, so ios26-v9.2.0-0 did not trigger npm publishing.

Match ios26-v* and strip that prefix when validating the package version. Update the README tag example. The main branch already correctly uses ios27-v* and needs no change.

Validation: confirmed the current branch configuration and verified ios26-v9.2.0-0 extracts to 9.2.0-0; diff check passed. No release was published. Existing tags still contain their original workflow; this fix applies to newly created tags containing the change.


Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@rdlabo
rdlabo merged commit c4db3f4 into ios26 Sep 10, 2026
10 of 13 checks passed
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Playwright test results

passed  90 passed

Details

stats  90 tests across 2 suites
duration  1 minute, 53 seconds
commit  73b3fa4
info  This detailed result covers Ionic 9 only. Ionic 8 runs against the same screenshots in a separate matrix job; check the workflow run for both results. To update the screenshots, comment with /update-screenshots.

@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-147/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📊 Ionic 9 Playwright Test Report

View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-147/

Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant